Fix: Users Unable to Upload Product Images if the store is private #12824

pmusolino · 2024-05-23T18:10:47Z

Description

The PR adds a notice in Product detail when a WP.com site is in Private mode since this makes the images not accessible.
This happens just on WP.com sites, since on self-hosted store it's not possible to put a store in the "private" state.
This has been already fixed here woocommerce/woocommerce-android#11383 and here woocommerce/woocommerce-android#11493 on Android.

Detail implementation

I decided to use a custom table view cell inside the image section instead of showing it as a banner, because it can happen to have another banner already displayed while the user is editing a product (or it can appear later). In this way, this notice in product images is always displayed when the store is private.

Testing instructions

Test 1

Log in to a WP.com site that is Public
Go to Products -> Tap on some product
Verify the images are available (either existing images or button to add one)
In wp-admin set the site to Private mode in Settings (more info here)
In the app, switch to a different site and switch back (or re-login, or close and reopen the app)
Go to Products -> Tap on some product
Verify a notice is displayed instead of an image gallery
Tap on the notice
Verify the privacy settings page is opened
Go back
In wp-admin set the site to Coming soon mode in the Settings
In the app, switch to a different site and switch back (or re-login, or close and reopen the app)
Go to Products -> Tap on some product
Verify the images are available (either existing images or button to add one)

Test 2

Create a self-hosted site with WooCommerce but without installing Jetpack or connecting a WP.com user using JCP
Log in to the app
Start creating a product
Verify the image uploading is available

Screenshots

Light mode	Dark mode

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…formation to products

…ally using SFSafariViewController. - Updated ProductFormTableViewDataSource to handle image configuration based on store visibility and editability.

wpmobilebot · 2024-05-23T18:19:09Z

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr12824-fde919c
	Version	18.9
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	`fde919c`
	App Center Build	WooCommerce - Prototype Builds #9412

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

itsmeichigo

Thanks for the fix @pmusolino! This test didn't pass for me:

In wp-admin set the site to Coming soon mode in the Settings
In the app, switch to a different site and switch back (or re-login, or close and reopen the app)
Go to Products -> Tap on some product
Verify the images are available (either existing images or button to add one)

itsmeichigo · 2024-05-27T09:59:37Z

Networking/Networking/Model/Site.swift

+    /// Returns true only if the site is hosted on WP.com and is private.
+    ///
+    var isPrivateWPCOMSite: Bool {
+        return isWordPressComStore && !isPublic


This logic includes only public sites. Is it possible to access images for sites with Coming soon status?

This is not expected, unfortunately. As you can see here C06NC969ZF0/p1715793466695389?thread_ts=1715193928.110329&cid=C06NC969ZF0 I was expecting that parsing blog_public limiting it to Atomic websites return private = true only if the store is private and not coming soon or public.

It seems btw that the app parse isPublic alias blog_public as a boolean, while it's an integer. From my tests, the values should be private = -1, coming soon = 0, public = 1. When it's -1, it's automatically false, that's why it works as expected. When it's coming soon, it's also false (0), and that's why you see the banner.

I'm going to address this

@itsmeichigo this is ready for another review!
Here are all the changes: a91a6fc

Below is the list of changes:

I removed the isPublic property from the Site model, which has been replaced with visibility, a property of type SiteVisibility. SiteVisibility is an enum that contains the values private = -1, coming soon = 0, public = 1.

Following the above change, I created a new Core Data model (version 112). As there is a data migration involved from the old Boolean value to the new Int64 in the database, there is also a new mapping model that converts the old Boolean value from model version 111 to the new Int64 in model version 112.

I updated all the code to use the new visibility property.

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormTableViewDataSource.swift

...erce/Classes/ViewRelated/Products/Edit Product/Cells/ImageAndTitleAndTextTableViewCell.swift

WooCommerce/Classes/ViewRelated/Products/Edit Product/DefaultProductFormTableViewModel.swift

…Images-on-iOS-App-if-the-store-is-private

…646-Users-Unable-to-Upload-Product-Images-on-iOS-App-if-the-store-is-private

… from Bool to int enum `SiteVisibility` + DB migration

dangermattic · 2024-05-30T17:33:29Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

itsmeichigo

I found issues with self-hosted sites when checking their visibility to display the Share option for products and Test order on the Orders tab, so I pushed a commit to fix that.

Although this works as described now, I'm not confident I didn't miss any edge cases. There aren't any migration tests for the migration from Core Data model version V111 to 112, and it's quite close to the code freeze, it's safer to delay the merge until the next version.

itsmeichigo · 2024-05-31T01:50:17Z

WooCommerce/Classes/ViewRelated/Orders/OrderListViewModel.swift

@@ -49,7 +49,7 @@ final class OrderListViewModel {
        }

        /// Enabled if site is launched, has published at least 1 product and set up payments.
-        return site.isPublic && hasAnyPaymentGateways && hasAnyPublishedProducts
+        return (site.visibility == .publicSite) && hasAnyPaymentGateways && hasAnyPublishedProducts


This fails for self-hosted sites because you were setting the default visibility for them as .comingSoon. I pushed a change in 44036af to make them public by default.

This is likely an error that existed previously since the WordPressSite had the isPublic property set to false, which was equivalent to comingSoon. Therefore, with the configuration I had in place, there should not have been any difference in behavior.

…_Site_entry`

pmusolino · 2024-05-31T14:30:10Z

Added the test for the migration from Core Data model version V111 to 112 408181a

itsmeichigo

Thanks for adding the migration test Paolo!

…Images-on-iOS-App-if-the-store-is-private

pmusolino added 11 commits May 20, 2024 15:35

fix: spaces in ProductFormTableViewDataSource

95f7966

fix: space ProductFormTableViewDataSource

07c0544

feat: introduced dynamic variable isPrivateWPCOMSite in Site model

c0d2eb5

feat: logic to understand is a wpcom store is private, passing the in…

8ba173c

…formation to products

feat: added titleTintColor into ImageAndTitleAndTextTableViewCell

fd046bf

- Introduced the presentURL(_:) method to handle URL presentation mod…

5b059b4

…ally using SFSafariViewController. - Updated ProductFormTableViewDataSource to handle image configuration based on store visibility and editability.

update: ProductFormActionsFactoryTests

54649ae

update: tests for isStorePublic

cf953f6

update: ProductFormActionsFactory_ReadonlyProductTests

6577162

fix: line lenght

e631fd7

feat: tests clean up

5fa6f8d

pmusolino added the feature: add/edit products Related to adding or editing products. label May 23, 2024

pmusolino added this to the 18.8 milestone May 23, 2024

pmusolino requested review from hafizrahman, selanthiraiyan and itsmeichigo May 23, 2024 18:10

pmusolino changed the title ~~Fix: Users Unable to Upload Product Images on iOS App if the store is private~~ Fix: Users Unable to Upload Product Images if the store is private May 23, 2024

jaclync modified the milestones: 18.8, 18.9 May 24, 2024

pmusolino added 2 commits May 24, 2024 12:22

fix: lines should be 163 characters or less

059db02

update: RELEASE-NOTES

60a6927

itsmeichigo self-assigned this May 27, 2024

itsmeichigo reviewed May 27, 2024

View reviewed changes

pmusolino added 6 commits May 27, 2024 16:29

fix: indentation

a3fd3bd

fix: typo

445234a

feat: removed unused StoresManager from DefaultProductFormTableViewModel

c2255b7

Merge branch 'trunk' into issue/12646-Users-Unable-to-Upload-Product-…

7223f38

…Images-on-iOS-App-if-the-store-is-private

Merge commit 'b3894996b5a6d897fbe75c8e93efdc8a84f1fa86' into issue/12…

2fac786

…646-Users-Unable-to-Upload-Product-Images-on-iOS-App-if-the-store-is-private

feat: migration of isPublic to -> visibility in the Site model,…

a91a6fc

… from Bool to int enum `SiteVisibility` + DB migration

pmusolino requested a review from itsmeichigo May 30, 2024 18:06

Set default visibility for self-hosted sites to be public

44036af

itsmeichigo reviewed May 31, 2024

View reviewed changes

hafizrahman modified the milestones: 18.9, 19.0 May 31, 2024

pmusolino added 3 commits May 31, 2024 11:45

update: release notes

b21ed6e

update: MIGRATIONS.md

a11871a

feat: implemented test method `test_migrating_from_111_to_112_updates…

408181a

…_Site_entry`

itsmeichigo approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'trunk' into issue/12646-Users-Unable-to-Upload-Product-…

fde919c

…Images-on-iOS-App-if-the-store-is-private

pmusolino enabled auto-merge June 3, 2024 09:05

pmusolino merged commit f067b31 into trunk Jun 3, 2024
22 checks passed

pmusolino deleted the issue/12646-Users-Unable-to-Upload-Product-Images-on-iOS-App-if-the-store-is-private branch June 3, 2024 09:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Users Unable to Upload Product Images if the store is private #12824

Fix: Users Unable to Upload Product Images if the store is private #12824

Uh oh!

pmusolino commented May 23, 2024

Uh oh!

wpmobilebot commented May 23, 2024 •

edited

Loading

Uh oh!

itsmeichigo left a comment

Uh oh!

itsmeichigo May 27, 2024

Uh oh!

pmusolino May 27, 2024

Uh oh!

pmusolino May 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dangermattic commented May 30, 2024 •

edited

Loading

Uh oh!

itsmeichigo left a comment

Uh oh!

itsmeichigo May 31, 2024

Uh oh!

pmusolino May 31, 2024

Uh oh!

pmusolino commented May 31, 2024

Uh oh!

itsmeichigo left a comment

Uh oh!

Uh oh!

Uh oh!

Fix: Users Unable to Upload Product Images if the store is private #12824

Fix: Users Unable to Upload Product Images if the store is private #12824

Uh oh!

Conversation

pmusolino commented May 23, 2024

Description

Detail implementation

Testing instructions

Test 1

Test 2

Screenshots

Uh oh!

wpmobilebot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

itsmeichigo May 27, 2024

Choose a reason for hiding this comment

Uh oh!

pmusolino May 27, 2024

Choose a reason for hiding this comment

Uh oh!

pmusolino May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dangermattic commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

itsmeichigo May 31, 2024

Choose a reason for hiding this comment

Uh oh!

pmusolino May 31, 2024

Choose a reason for hiding this comment

Uh oh!

pmusolino commented May 31, 2024

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented May 23, 2024 •

edited

Loading

dangermattic commented May 30, 2024 •

edited

Loading